Poor SDK Code Quality

Poor SDK Code Quality

BY 10 Jul 2015 SDK & IDE

While playing with the SDK I noticed some realy bad stuff. Documenting here in the hopes to having it fixed:

InstallManager (really bad code quality):

  • Installation doesn’t succeed when folders already exist because an exception will cause the installer to abort when a file can’t be hardlinked.
  • InstallManager (java) uses shell commands to copy/remove files. Java has great support for file operations such that there is no need to use shell commands, especially if it makes the code more complex and less portable.
  • Over-eagerly uses exceptions when return values would be perfectly fine

SDK:

  • Require root privileges for installation: some scripts relink stuff from my distribution – the SDK *REALLY* shouldn’t touch my system! It’s a user component that has no business changing the system.
  • Building a project Tried erasing my harddrive when i ran “make clean” on a native project -> when SA_REPORT_PATH is not set, rm -rf /* is executed. I also managed to trigger this from within the SDK by accident – not cool! Get rid of the wildcard in the makefile or at the very least check if the variable is empty before applying the wildcard on it.
  • Lacks x86_64 target support
  • (Is based on eclipse…)
Written by